Todd Lipcon has posted comments on this change. Change subject: KUDU-745 / KUDU-1463 tablet's table id attribute is empty string ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3183/2//COMMIT_MSG Commit Message: Line 12: versus the master's /tables. Is this expected? can you give an example? it doesn't seem expected to me :) A unit test would also be good to verify. You can add an assertion to tablet_server-test.cc:194 to check for the expected table ID Line 16: is "sys.catalog". I think we should do something to distinguish the ID from the name here. http://gerrit.cloudera.org:8080/#/c/3183/2/src/kudu/tablet/tablet-harness.h File src/kudu/tablet/tablet-harness.h: Line 92: "KuduTableTest", distinguish the ID from the name to make it more clear in logs, etc http://gerrit.cloudera.org:8080/#/c/3183/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 178: //attrs["table_id"] = "booya"; dead code? -- To view, visit http://gerrit.cloudera.org:8080/3183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1795a176312f6c2a55c34b7b684ee408f1cf8732 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes