Dan Burkert has posted comments on this change. Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc File src/kudu/benchmarks/tpch/rpc_line_item_dao.cc: Line 18: #include <boost/function.hpp> > Used? yes, it used and was previously not included. http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/consensus/consensus-test-util.h File src/kudu/consensus/consensus-test-util.h: Line 18: #include <boost/bind.hpp> > used? yes, it used and was previously not included. http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/experiments/rwlock-perf.cc File src/kudu/experiments/rwlock-perf.cc: Line 19: #include <boost/smart_ptr/detail/yield_k.hpp> > i don't see yield here. needed? nope; removed. -- To view, visit http://gerrit.cloudera.org:8080/3262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c27f72c726258793991006a728673af537414bb Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes