Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3275
to review the following change.
Change subject: Add TableCreator::add_range_split and deprecate
TableCreator::split_rows
......................................................................
Add TableCreator::add_range_split and deprecate TableCreator::split_rows
TableCreator::split_rows took a vector<const KuduPartialRow*>, which make it
very difficult for the calling application to do proper error handling with
cleanup when setting the fields of the partial row. Taking the range split rows
one by one allows the application to wrap the partial row in a unique_ptr 'end
to end', and handle errors correctly. client-test has been updated to use the
new API, and now handles errors correctly when initializing split rows.
Change-Id: I72cc152ff4b01834abd3c7b6fc32980ceb789c69
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
5 files changed, 39 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/3275/1
--
To view, visit http://gerrit.cloudera.org:8080/3275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72cc152ff4b01834abd3c7b6fc32980ceb789c69
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
