Todd Lipcon has posted comments on this change. Change subject: kudu-1475: set is is_initialized_ to false in log pre-allocated case ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3284/3/src/kudu/consensus/log_reader.cc File src/kudu/consensus/log_reader.cc: Line 150: VLOG(WARNING) << "Uninitialized segment at: " << segment->path(); VLOG(WARNING) doesn't really exist (surprising it compiles). Should be VLOG(1) probably. Or, if we want it to be a warning that the user sees, I think it should probably be LOG(INFO) and contain an extra sentence about what this actually means (i.e that the server probably crashed in between creating this log and writing the header) -- To view, visit http://gerrit.cloudera.org:8080/3284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b2beb7c669b1821be8242f45fcea4c6ae269a0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: song bruce zhang <zsyuyizh...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: song bruce zhang <zsyuyizh...@gmail.com> Gerrit-HasComments: Yes
