Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3255/4/src/kudu/integration-tests/flex_partitioning-itest.cc File src/kudu/integration-tests/flex_partitioning-itest.cc: PS4, Line 185: // Tablets aren't always immediately dropped, spin until they are gone. : for (int i = 1; CountTablets() > 0; i++) { : CHECK_LE(i, 30); : base::SleepForMilliseconds(10 * i); : } > Why is this important for the correctness of these tests? Done PS4, Line 250: CHECK_OK(itest::CreateTabletServerMap(cluster_->master_proxy().get(), : cluster_->messenger(), : &ts_map)); : : vector<tserver::ListTabletsResponsePB_StatusAndSchemaPB> tablets; : CHECK_OK(ListTablets(ts_map.begin()->second, MonoDelta::FromSeconds(10), &tablets)); : return tablets.size(); > It's a method on MasterServiceProxy. Done -- To view, visit http://gerrit.cloudera.org:8080/3255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cb12704c5e9792ee6e5831568bc52b1a713f8d5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
