David Ribeiro Alves has submitted this change and it was merged. Change subject: Make 'num_attempts' in RequestIdPB required ......................................................................
Make 'num_attempts' in RequestIdPB required We need to differentiate between attempts, on the server, so that we can handle dangling handlers when multiple attempts at the same RPC are happening at the same time (e.g. a client-originated write rpc and the same rpc originating from another replica). Differentiating which attempt is executing on the server side requires distinguishing between different attempts. Using 'num_attempts' is a natural way to do so. Change-Id: Idd8f780826438278993554546edfae90bf1a39df Reviewed-on: http://gerrit.cloudera.org:8080/3408 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/rpc/rpc_header.proto 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd8f780826438278993554546edfae90bf1a39df Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
