Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient ......................................................................
Patch Set 2: > Looks fine, but the cascading series of fixes to this code has left > me with zero confidence that we got it right. Could you please add > some automated test coverage? Unit tests would be ideal, but > integration or stress tests would be fine too. Maybe a stress test > where the client is aggressively disconnected from the servers, to > exercise these code paths? TBH I've spent at least 3 days worth of time trying to repro these issues with a single test. I'm either just not doing the right thing or it'll require more code instrumentation. But I agree with you that we can't just rely on hours long cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/3586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f92a2f9464f245182a59178f2eab8a88422864c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
