Alexey Serbin has posted comments on this change. Change subject: WIP: ts-cli: add commands to trigger step-down and copying tablets ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3582/1/src/kudu/tools/ts-cli.cc File src/kudu/tools/ts-cli.cc: Line 339: Status TsAdminClient::CopyTablet(const string& tablet_id, Design of this class assumes a caller might call this method on invalid/non-initialized object. Does it make sense to add CHECK(initted_) as the very first line? Line 382: Status TsAdminClient::StepDown(const string& tablet_id) { Ditto for CHECK(initted_) or may be embed that check into GetStatus() call, otherwise it might be SIGSEGV in GetStatus(). -- To view, visit http://gerrit.cloudera.org:8080/3582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94fd59c307d4f5d921d5975a19ca1f3116c6ff70 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
