Todd Lipcon has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results ......................................................................
Patch Set 26: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3190/26/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: Line 244: // CompletionRecords. OK, I still think this iteration order thing is fragile, but I've made a note to come back to it. http://gerrit.cloudera.org:8080/#/c/3190/26/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: Line 131: // result_tracker_->TrackRpcOrChangeDriver(request_id); woohoo, I like this much better. thanks for taking the time to re-work it -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 26 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
