Todd Lipcon has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method ......................................................................
Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3191/15/src/kudu/rpc/rpc_context.h File src/kudu/rpc/rpc_context.h: Line 91: void RespondFailure(); > the problem is that results are not always being cached and for most RPCs t On the other hand, the issue now is that a service implementor can call 'RespondFailure()' but the caller on the other side gets no indication that the response was not successful. If we want to use this consistently for any "failures indicated by an error field in the response' then we'd have a much bigger job to go through all RPCs to do the replacement. Right now we're only using this new method for writes, so in my mind it makes sense to explicitly say 'NoCache' because the implementor of writes is being careful to understand caching behavior. Also, we have TODOs elsewhere to rename 'RespondSuccess' to just 'Respond', in which case 'RespondNoCache' fits well (it's the same as respond, minus the caching of it) -- To view, visit http://gerrit.cloudera.org:8080/3191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
