David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes ......................................................................
Patch Set 25: (13 comments) http://gerrit.cloudera.org:8080/#/c/3449/25/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: PS25, Line 210: it's > nit: its Done PS25, Line 268: er."); > Any more info that we can add here? Added the request id. Note that the user won't see this as the request is transparently retried. http://gerrit.cloudera.org:8080/#/c/3449/25/src/kudu/tablet/transactions/transaction_driver.h File src/kudu/tablet/transactions/transaction_driver.h: PS25, Line 124: client originated > nit: client-originated Done PS25, Line 124: a > nit: remove Done PS25, Line 149: to to > nit Done PS25, Line 155: it's > nit: its Done PS25, Line 156: requests > nit: request? same for the other "requests" on that line. Done PS25, Line 157: > nit Done PS25, Line 168: and > nit: remove that 'and' Done PS25, Line 169: received > nit: receive Done PS25, Line 302: drivers > nit: driver Done http://gerrit.cloudera.org:8080/#/c/3449/25/src/kudu/tablet/transactions/write_transaction.h File src/kudu/tablet/transactions/write_transaction.h: PS25, Line 192: pointers to the rpc context, request and response, lifecyle : // is managed by the rpc subsystem. > Since you're here, mind rewriting this sentence? Start with upper case, the Done PS25, Line 194: Request > nit: 'request_' Done -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
