Todd Lipcon has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3643/5//COMMIT_MSG Commit Message: Line 13: there was a way to mock a server-side krpc component as easily as it is to what about injecting a master crash in the AsyncSendFoo() method? that would be likely to trigger this in many cases, right? (not a guarantee that the response was quicker than the starting of the async stuff, but pretty likely I think?) Line 15: multi-master tests, though. is there a test you can loop before/after to verify this? http://gerrit.cloudera.org:8080/#/c/3643/5/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: Line 175: // Indicates that the thread should set a full tablet report. Set when s/set/send/ -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
