Dan Burkert has posted comments on this change.

Change subject: KUDU-1374: send full tablet report when new leader master is 
detected
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3643/6/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 156: DEFINE_bool(catalog_manager_fail_async_rpcs, false,
what about swapping 'async' for 'ts'.  When I read the previous test, my first 
question was "how is the alter table replicated to the other masters if all 
async RPCs are disabled?"


-- 
To view, visit http://gerrit.cloudera.org:8080/3643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to