andrasbeni commented on a change in pull request #312:
URL: https://github.com/apache/incubator-livy/pull/312#discussion_r499263261
##########
File path: bin/livy-server
##########
@@ -102,6 +102,10 @@ start_livy_server() {
LIVY_CLASSPATH="$LIVY_CLASSPATH:$YARN_CONF_DIR"
fi
+ if [ -n "$LIVY_LOG_DIR" ]; then
+ LIVY_SERVER_JAVA_OPTS="-DLIVY_LOG_DIR=$LIVY_LOG_DIR $LIVY_SERVER_JAVA_OPTS"
Review comment:
As I can see, the value of $LIVY_LOG_DIR is used only in the example in
log4j template. As such, I don't think it's worth adding it here. Especially,
because users can add the log dir definition to LIVY_SERVER_JAVA_OPTS right
where they export it.
##########
File path:
server/src/main/scala/org/apache/livy/server/interactive/InteractiveSessionAudit.scala
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.interactive
+
+import org.apache.livy.Logging
+
+object InteractiveSessionAudit extends Logging {
+ def audit(
+ id: Int,
+ appId: String,
+ owner: String,
+ proxyUser: String,
+ queue: String,
+ kind: String,
+ code: String): Unit = {
+ info(s"Executing statement in interactive session $id, appId: $appId, " +
Review comment:
Logging the statements on INFO level is unfortunate because by default
these logs will end up in the same log file (unless users modify their log4j
config when upgrading). DEBUG level is more appropriate (and is shown in the
commit message).
I'd like this even more if there were a LivyConf entry to switch off audit
logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
