sergeymazin commented on a change in pull request #312:
URL: https://github.com/apache/incubator-livy/pull/312#discussion_r499422034
##########
File path: bin/livy-server
##########
@@ -102,6 +102,10 @@ start_livy_server() {
LIVY_CLASSPATH="$LIVY_CLASSPATH:$YARN_CONF_DIR"
fi
+ if [ -n "$LIVY_LOG_DIR" ]; then
+ LIVY_SERVER_JAVA_OPTS="-DLIVY_LOG_DIR=$LIVY_LOG_DIR $LIVY_SERVER_JAVA_OPTS"
Review comment:
Yep, you are right.
But this is added because if you define $LIVY_LOG_DIR in `livy-env.sh` file
it won't be passed to JVM as system var and you won't be able to use it in
log4j out-of-the-box, additionally, you have to set the same variable second
time in $LIVY_SERVER_JAVA_OPTS also. I think this is duplication and end user
doesn't have to deal with it.
It took me also some time to figure out why it doesn't work, so decided to
make it better for others also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
