mgaido91 commented on a change in pull request #162: [LIVY-572] Avoid usage of 
spark classes in ColumnBuffer
URL: https://github.com/apache/incubator-livy/pull/162#discussion_r269256355
 
 

 ##########
 File path: 
thriftserver/session/src/main/java/org/apache/livy/thriftserver/session/ResultSet.java
 ##########
 @@ -43,7 +63,13 @@ public void addRow(Object[] fields) {
     }
 
     for (int i = 0; i < fields.length; i++) {
-      columns[i].add(fields[i]);
+      Object value;
+      if (columnIsString[i]) {
 
 Review comment:
   ok, done, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to