reviews

Messages by Date

2020/09/10 Re: Review Request 72856: Fixed Website bot to work with docker user namespaces. Andrei Sekretenko
2020/09/10 Review Request 72858: Reduced build parallelism to avoid aborted builds in CI. Vinod Kone
2020/09/10 Review Request 72857: Merged build.sh and entrypoint.sh. Vinod Kone
2020/09/10 Review Request 72856: Fixed Website bot to work with docker user namespaces. Vinod Kone
2020/09/09 Re: Review Request 72851: Added an endpoint for debugging offer constraints. Mesos Reviewbot
2020/09/09 Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Benjamin Mahler
2020/09/09 Re: Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf. Benjamin Mahler
2020/09/09 Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Benjamin Mahler
2020/09/09 Re: Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master. Benjamin Mahler
2020/09/09 Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Mesos Reviewbot
2020/09/09 Re: Review Request 72851: Added an endpoint for debugging offer constraints. Andrei Sekretenko
2020/09/09 Re: Review Request 72846: Corrected the example of the managed CSI plugin. Mesos Reviewbot
2020/09/09 Review Request 72851: Added an `/offer_constraints_debug` endpoint. Andrei Sekretenko
2020/09/09 Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Mesos Reviewbot
2020/09/09 Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Andrei Sekretenko
2020/09/09 Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Andrei Sekretenko
2020/09/09 Re: Review Request 72845: Added doc for the `volume/csi` isolator. Mesos Reviewbot
2020/09/09 Re: Review Request 72830: Added a regression test for MESOS-9609. Mesos Reviewbot
2020/09/09 Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Mesos Reviewbot
2020/09/08 Re: Review Request 72846: Corrected the example of the managed CSI plugin. Qian Zhang
2020/09/08 Review Request 72846: Corrected the example of the managed CSI plugin. Qian Zhang
2020/09/08 Re: Review Request 72845: Added doc for the `volume/csi` isolator. Qian Zhang
2020/09/08 Review Request 72845: Added doc for the `volume/csi` isolator. Qian Zhang
2020/09/08 Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Mesos Reviewbot
2020/09/08 Re: Review Request 72830: Added a regression test for MESOS-9609. Greg Mann
2020/09/08 Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Greg Mann
2020/09/08 Re: Review Request 72831: Fixed a CHECK failure in master during agent removal. Greg Mann
2020/09/08 Re: Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
2020/09/08 Re: Review Request 72831: Fixed a CHECK failure in master during agent removal. Benjamin Mahler
2020/09/08 Re: Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
2020/09/08 Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Benjamin Mahler
2020/09/08 Re: Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`. Benjamin Mahler
2020/09/08 Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Benjamin Mahler
2020/09/08 Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Andrei Sekretenko
2020/09/07 Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Andrei Sekretenko
2020/09/07 Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf. Andrei Sekretenko
2020/09/07 Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Andrei Sekretenko
2020/09/07 Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master. Andrei Sekretenko
2020/09/07 Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`. Andrei Sekretenko
2020/09/04 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/03 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
2020/09/03 Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
2020/09/03 Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
2020/09/03 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
2020/09/03 Re: Review Request 72790: Deduplicated concurrent image pulls by docker store. Andrei Sekretenko
2020/09/03 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
2020/09/03 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/09/03 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/09/03 Re: Review Request 72794: Added a test for discarding image pull on discard of getting image. Qian Zhang
2020/09/03 Re: Review Request 72793: Added discarding a future returned by get() into the docker store test. Qian Zhang
2020/09/03 Re: Review Request 72792: Fixed typos in the name of `PullingSameImageSimutanuously` test. Qian Zhang
2020/09/03 Re: Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test. Qian Zhang
2020/09/03 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/02 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
2020/09/02 Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Benjamin Mahler
2020/09/02 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/02 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/09/02 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/09/02 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
2020/09/02 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
2020/09/02 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/09/02 Re: Review Request 72790: Deduplicated concurrent image pulls by docker store. Qian Zhang
2020/09/02 Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Andrei Sekretenko
2020/09/02 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
2020/09/02 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
2020/09/02 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/09/02 Re: Review Request 72805: Added a test helper for CSI volumes. Qian Zhang
2020/09/01 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/09/01 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/01 Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
2020/09/01 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/09/01 Re: Review Request 72805: Added a test helper for CSI volumes. Greg Mann
2020/09/01 Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Mesos Reviewbot
2020/09/01 Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Mesos Reviewbot
2020/09/01 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
2020/09/01 Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
2020/09/01 Review Request 72831: Fixed a CHECK failure in master during agent removal. Benjamin Mahler
2020/09/01 Review Request 72832: Avoided unnecessary [] map operators in the master. Benjamin Mahler
2020/09/01 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
2020/09/01 Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
2020/09/01 Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Greg Mann
2020/09/01 Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Mesos Reviewbot
2020/09/01 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
2020/09/01 Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Mesos Reviewbot
2020/09/01 Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Mesos Reviewbot
2020/09/01 Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Qian Zhang
2020/09/01 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
2020/08/31 Re: Review Request 72804: Enabled CSI volume access for non-root users. Qian Zhang
2020/08/31 Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Benjamin Mahler
2020/08/31 Re: Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time. Benjamin Mahler
2020/08/31 Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
2020/08/31 Re: Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED. Benjamin Mahler
2020/08/31 Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
2020/08/31 Re: Review Request 72816: Fixed broken authorization in the CSI server. Greg Mann
2020/08/31 Re: Review Request 72820: Relaxed unknown volume check when unpublishing volumes. Greg Mann
2020/08/31 Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Greg Mann
2020/08/31 Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time. Andrei Sekretenko
2020/08/31 Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Andrei Sekretenko
2020/08/31 Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
2020/08/31 Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED. Andrei Sekretenko
2020/08/31 Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
2020/08/30 Re: Review Request 72816: Fixed broken authorization in the CSI server. Qian Zhang
2020/08/29 Review Request 72820: Relaxed unknown volume check when unpublishing volumes. Qian Zhang
2020/08/29 Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
2020/08/29 Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
2020/08/28 Re: Review Request 72805: Added a test helper for CSI volumes. Greg Mann
2020/08/28 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/28 Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Greg Mann
2020/08/28 Re: Review Request 72727: Updated the test CSI plugin for CSI server testing. Greg Mann
2020/08/28 Review Request 72816: Fixed broken authorization in the CSI server. Greg Mann
2020/08/28 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/27 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/27 Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
2020/08/27 Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
2020/08/27 Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
2020/08/27 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/27 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/08/26 Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Mesos Reviewbot
2020/08/26 Re: Review Request 72787: Added basic tests for regexp-based constraints. Benjamin Mahler
2020/08/26 Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
2020/08/26 Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Greg Mann
2020/08/26 Review Request 72806: Added a test for 'volume/csi' isolator recovery. Greg Mann
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Mesos Reviewbot
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/26 Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
2020/08/26 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/26 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Mesos Reviewbot
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/08/26 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Qian Zhang
2020/08/25 Re: Review Request 72805: Added a test helper for CSI volumes. Qian Zhang
2020/08/25 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/25 Re: Review Request 72728: Added tests for the 'volume/csi' isolator. Greg Mann
2020/08/25 Review Request 72805: Added a test helper for CSI volumes. Greg Mann
2020/08/25 Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Mesos Reviewbot
2020/08/25 Review Request 72803: Added a new agent flag `--csi_volume_chown`. Qian Zhang
2020/08/25 Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
2020/08/25 Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
2020/08/25 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/25 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/25 Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
2020/08/25 Re: Review Request 72728: Added unit tests for the CSI server. Qian Zhang
2020/08/25 Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction. Mesos Reviewbot
2020/08/25 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/25 Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality. Andrei Sekretenko
2020/08/24 Re: Review Request 72727: Updated the test CSI plugin for CSI server testing. Qian Zhang
2020/08/24 Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Qian Zhang
2020/08/24 Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator. Qian Zhang
2020/08/24 Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator. Qian Zhang
2020/08/24 Re: Review Request 72799: Fixed a bug in CSI server initialization. Greg Mann
2020/08/24 Re: Review Request 72799: Fixed a bug in CSI server initialization. Qian Zhang
2020/08/24 Re: Review Request 72799: Fixed a bug in CSI server initialization. Greg Mann
2020/08/24 Re: Review Request 72728: Added unit tests for the CSI server. Mesos Reviewbot
2020/08/24 Review Request 72799: Fixed a data race in the CSI server. Greg Mann
2020/08/24 Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
2020/08/24 Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
2020/08/24 Re: Review Request 72728: Added unit tests for the CSI server. Greg Mann
2020/08/24 Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Benjamin Mahler
2020/08/24 Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality. Benjamin Mahler
2020/08/24 Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction. Mesos Reviewbot
2020/08/24 Re: Review Request 72775: Implemented offer constraints on a string attribute equality. Benjamin Mahler
2020/08/24 Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality. Benjamin Mahler
2020/08/24 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/24 Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
2020/08/24 Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
2020/08/24 Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality. Andrei Sekretenko
2020/08/24 Re: Review Request 72775: Implemented offer constraints on a string attribute equality. Andrei Sekretenko
2020/08/24 Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality. Andrei Sekretenko
2020/08/24 Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality. Andrei Sekretenko
2020/08/24 Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality. Benjamin Mahler
2020/08/24 Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Greg Mann
2020/08/23 Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Mesos Reviewbot
2020/08/23 Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
2020/08/23 Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
2020/08/23 Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
2020/08/21 Re: Review Request 72728: Added unit tests for the CSI server. Mesos Reviewbot
2020/08/21 Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
2020/08/21 Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
2020/08/21 Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Greg Mann
2020/08/21 Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON. Greg Mann
2020/08/21 Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Mesos Reviewbot
2020/08/21 Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality. Andrei Sekretenko
2020/08/21 Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
2020/08/21 Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Qian Zhang
2020/08/21 Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot
2020/08/21 Re: Review Request 72727: Updated the test CSI plugin for CSI server testing. Mesos Reviewbot
2020/08/20 Re: Review Request 72728: Added unit tests for the CSI server. Greg Mann
2020/08/20 Re: Review Request 72761: Added the CSI server to the Mesos agent. Greg Mann
2020/08/20 Re: Review Request 72728: Added unit tests for the CSI server. Greg Mann
2020/08/20 Re: Review Request 72779: Initialized plugins lazily in the CSI server. Qian Zhang