> On April 21, 2015, 3:27 a.m., Joris Van Remoortere wrote:
> > .gitignore-template, lines 22-33
> > <https://reviews.apache.org/r/33376/diff/1/?file=937063#file937063line22>
> >
> >     I think this got added to your commit accidentaly? If you want to add 
> > this to the repository we should make a separate JIRA and review for this.
> 
> Marco Massenzio wrote:
>     it was not accidental - but, really: do you need a review to add ignore 
> files? it seems a bit overkill to me.
> 
> Joris Van Remoortere wrote:
>     See my high-level comment.

reverted changes


> On April 21, 2015, 3:27 a.m., Joris Van Remoortere wrote:
> > src/Makefile.am, lines 302-304
> > <https://reviews.apache.org/r/33376/diff/1/?file=937065#file937065line302>
> >
> >     I don't think you meant to change the spacing of all these lines 
> > (highlighted and rest of file). Can you check your editor settings to see 
> > if you're modifying them accidentally?
> 
> Marco Massenzio wrote:
>     the right-hand side continuation \ was all over the place and looked 
> honestly awful: I follow the "boyscout principle" and just lined up quite a 
> few of them around the *one* change I made (adding `framework.cpp`) - 
> hopefully this should upset no one?
> 
> Joris Van Remoortere wrote:
>     I think we might have different whitespace modifiers in our editors. 
> Let's sync up as in my high-level comment.

reverted


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33376/#review80894
-----------------------------------------------------------


On April 21, 2015, 7:06 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33376/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2633
>     https://issues.apache.org/jira/browse/MESOS-2633
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created new file framework.cpp containing all the methods' implementations 
> for the `Framework` class (declared in master/master.hpp)
> 
> Declared `operator ==` for Task in type_utils.hpp 
> (it was implemented before, but not declared in the header file);
> 
> Refactored all the LOG(WARNING) to a single utility method.
> 
> 
> Diffs
> -----
> 
>   .gitignore-template 1a8e2a8677a29f06ba6386d56537a0013d38821c 
>   include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 
>   src/Makefile.am d15a37365bcdd5c3906160b46b389635b38b1673 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc 
> 
> Diff: https://reviews.apache.org/r/33376/diff/
> 
> 
> Testing
> -------
> 
> All tests (make check) pass.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to