> On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote: > > src/master/framework.cpp, lines 185-186 > > <https://reviews.apache.org/r/33376/diff/3/?file=939881#file939881line185> > > > > Can you find other places in the code where the TODOs are aligned like > > this? > > It's definitely neat, but it seems to be different from other places. > > Marco Massenzio wrote: > I actually did ask Nik - and he suggested this. > I'll check out other TODO's in the code base
Most multiline TODO's seem to just continue without the lined-up indent Google style guid is silent on the topic (AFAICT) The line is anyway gone - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/#review82004 ----------------------------------------------------------- On April 22, 2015, 8:35 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33376/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 8:35 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-2633 > https://issues.apache.org/jira/browse/MESOS-2633 > > > Repository: mesos > > > Description > ------- > > Created new file framework.cpp containing all the methods' implementations > for the `Framework` class (declared in master/master.hpp) > > Declared `operator ==` for Task in type_utils.hpp > (it was implemented before, but not declared in the header file); > > Refactored all the LOG(WARNING) to a single utility method. > > > Diffs > ----- > > include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/master/framework.cpp PRE-CREATION > src/master/master.hpp 550d2c50cd01aa5830a7e7e03ab4a0240c221b15 > > Diff: https://reviews.apache.org/r/33376/diff/ > > > Testing > ------- > > All tests (make check) pass. > > > Thanks, > > Marco Massenzio > >
