> On April 22, 2015, 11:24 a.m., Alexander Rukletsov wrote:
> > Let's not repeat summary in description. How about the following:
> > "StatusUpdateStream is not a template, hence we can reduce compilation time 
> > by moving method definitions into a `.cpp` file. As a drive-by change 
> > headers are cleaned up."
> > 
> > Thank you for putting effort into reducing compilation time!
> 
> Ben Mahler wrote:
>     > Thank you for putting effort into reducing compilation time!
>     
>     Was it measured? :)

I did measure it, but status_update_manager is not widely included, so in 
practice there was not really performance gain. Still I think it's not only 
about compilation time, but reducing the ammount of inlined code.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81136
-----------------------------------------------------------


On April 22, 2015, 11:09 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2609
>     https://issues.apache.org/jira/browse/MESOS-2609
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
> 
> 
> Diffs
> -----
> 
>   src/slave/status_update_manager.hpp 
> b4d91b22b515195fdb69c89af9c2864e469e7e54 
>   src/slave/status_update_manager.cpp 
> fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 
> 
> Diff: https://reviews.apache.org/r/33358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to