> On April 8, 2015, 10:38 p.m., Jie Yu wrote: > > src/master/validation.cpp, line 61 > > <https://reviews.apache.org/r/32150/diff/5/?file=920955#file920955line61> > > > > Do you want to add a `CHECK_NE(resource.role(), "*");` here. > > > > That makes me wonder should we move the check in Resources::validate > > about `"*"` and `ReservationInfo` here. This sounds like a more high level > > semantical check, while checks in Resources::validate are all quite low > > level (e.g., check for invalid name, type name mismatch, etc.). > > > > What do you think?
Synced with Jie on IRC regarding this. The summary is captured [here](https://reviews.apache.org/r/32140/#comment131682). - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review79442 ----------------------------------------------------------- On April 15, 2015, 3:55 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 3:55 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2139 > https://issues.apache.org/jira/browse/MESOS-2139 > > > Repository: mesos > > > Description > ------- > > Handled reservation operations in `Master::_accept`. > > Added `validate` functions in `src/master/validation.{hpp,cpp}`. > > > Diffs > ----- > > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec > src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e > src/tests/master_validation_tests.cpp > 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 > > Diff: https://reviews.apache.org/r/32150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >