> On April 29, 2015, 9:54 a.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, lines 2486-2488
> > <https://reviews.apache.org/r/32150/diff/5-8/?file=920953#file920953line2486>
> >
> > This looks a bit weird. Is it what `clang-format` proposes?
>
> Michael Park wrote:
> It is indeed. Do you have a preferred formatting? I couldn't really find
> one that I consider to be the definitive answer so I went with this.
If in doubt, go for consistency:
`stout/flags/flags.hpp:182`
`stout/flags/flags.hpp:247`
`libprocess/src/http.cpp:664`
I think this is simple, readable and kind of consistent with our style guide:
```
Option<string> principal = framework->info.has_principal()
? framework->info.principal()
: Option<string>::none();
```
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/#review81945
-----------------------------------------------------------
On April 28, 2015, 10:43 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32150/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 10:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2139
> https://issues.apache.org/jira/browse/MESOS-2139
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handled reservation operations in `Master::_accept`.
>
> Added `validate` functions in `src/master/validation.{hpp,cpp}`.
>
>
> Diffs
> -----
>
> src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e
> src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec
> src/master/validation.cpp dc25995bf57397d42fcde458414f0402d19bf792
> src/tests/master_validation_tests.cpp
> 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395
>
> Diff: https://reviews.apache.org/r/32150/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
