----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32108/#review81771 -----------------------------------------------------------
Bad patch! Reviews applied: [32108] Failed command: ./support/apply-review.sh -n -r 32108 Error: 2015-04-28 02:06:21 URL:https://reviews.apache.org/r/32108/diff/raw/ [8090/8090] -> "32108.patch" [1] Successfully applied: Added manual make for readability training source code Readability source code now has a Makefile that is generated by bootstrap and configure. "cd build/readability; make" compiles the sources in "readability/". No linking occurs. This is just to ensure that we have syntactially correct and type-checked example files. Slightly rearranged the content of naming_*.cpp and broke out an extra file for whitespace issues. Replaces: https://reviews.apache.org/r/31990/ https://reviews.apache.org/r/31992/ Review: https://reviews.apache.org/r/32108 No files to lint .git/hooks/pre-commit: 37: cd: can't cd to build/readability make: *** No targets specified and no makefile found. Stop. Failed to commit patch - Mesos ReviewBot On April 28, 2015, 1:44 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32108/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 1:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Readability source code now has a Makefile that is generated by bootstrap and > configure. "cd build/readability; make" compiles the sources in > "readability/". No linking occurs. This is just to ensure that we have > syntactially correct and type-checked example files. > > Slightly rearranged the content of naming_*.cpp and broke out an extra file > for whitespace issues. > > Replaces: > https://reviews.apache.org/r/31990/ > https://reviews.apache.org/r/31992/ > > > Diffs > ----- > > configure.ac 589ae97d0432370b462576cd1985544564893999 > readability/Makefile.am PRE-CREATION > readability/README.md PRE-CREATION > readability/naming_comments.cpp PRE-CREATION > readability/naming_review.cpp PRE-CREATION > readability/whitespace_comments.cpp PRE-CREATION > readability/whitespace_review.cpp PRE-CREATION > support/hooks/pre-commit 09ce57816b4aa953fea6bd9574223626edb23699 > > Diff: https://reviews.apache.org/r/32108/diff/ > > > Testing > ------- > > cd build/readability; make > > Also observed that the pre-commit hook does this as well. > > > Thanks, > > Bernd Mathiske > >
