> On April 29, 2015, 2:51 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 209
> > <https://reviews.apache.org/r/30609/diff/5/?file=891428#file891428line209>
> >
> >     Add a short comment on what this test does, please. We are trying to 
> > get this done for all new tests and for all those we touch.

Good point. Will do.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review82028
-----------------------------------------------------------


On March 11, 2015, 10:06 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30609/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 10:06 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-2072
>     https://issues.apache.org/jira/browse/MESOS-2072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This returns a file's size (on UNIXes as reported by lstat(), not stat()). It 
> is desired that in case of a link, the size of the link, not the size of the 
> referenced file, is returned.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/stat.hpp 
> af940a48b161c194f2efb529b3d589c543b12f61 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> c396c1d2d833b2f1721092fa35b23b5c3c3d99b3 
> 
> Diff: https://reviews.apache.org/r/30609/diff/
> 
> 
> Testing
> -------
> 
> Wrote a simple test that creates a file and tests its size, and also checks 
> if a non-existing file yields an error.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to