----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/#review83428 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/stat.hpp <https://reviews.apache.org/r/30609/#comment134410> DO_NOT_FOLLOW_SYM_LINKS seems to be just a arbitrary name? DO_NOW_FOLLOW is what you chose to be the enum value 3rdparty/libprocess/3rdparty/stout/include/stout/os/stat.hpp <https://reviews.apache.org/r/30609/#comment134409> Wouldn't you want to switch on an enum so when new enums are added you can get an warning? - Timothy Chen On May 12, 2015, 6:48 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30609/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 6:48 a.m.) > > > Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > This returns a file's size (on UNIXes as reported by lstat(), not stat()). It > is desired that in case of a link, the size of the link, not the size of the > referenced file, is returned. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/stat.hpp > 270c4c848fc0460dcdb9a90823281d735f4550c2 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 343f95be7f316170b37c9358627f3c2090f0e29e > > Diff: https://reviews.apache.org/r/30609/diff/ > > > Testing > ------- > > Wrote a simple test that creates a file and tests its size, and also checks > if a non-existing file yields an error. > > > Thanks, > > Bernd Mathiske > >
