----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32837/#review82206 -----------------------------------------------------------
src/slave/state.hpp <https://reviews.apache.org/r/32837/#comment132903> It seems a bit odd to put the top-level state in the middle, before one can see the tree structure through the order they're listed in the header. Why not just forward declare above? - Ben Mahler On April 30, 2015, 4:22 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32837/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 4:22 p.m.) > > > Review request for mesos, Ben Mahler, Cody Maloney, and Michael Park. > > > Bugs: MESOS-1991 > https://issues.apache.org/jira/browse/MESOS-1991 > > > Repository: mesos > > > Description > ------- > > Prep for unrestricted union Option<T>. > > > Diffs > ----- > > src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02 > > Diff: https://reviews.apache.org/r/32837/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
