> On April 30, 2015, 9:45 p.m., Ben Mahler wrote:
> > src/slave/state.hpp, lines 214-227
> > <https://reviews.apache.org/r/32837/diff/1/?file=914977#file914977line214>
> >
> >     It seems a bit odd to put the top-level state in the middle, before one 
> > can see the tree structure through the order they're listed in the header. 
> > Why not just forward declare above?

This is necessary because the compiler now needs to know the entire definition 
of certain structs in order to figure out the size to allocate static memory 
for each Option<T>. Thus, I put everything in reverse dependency order, 'struct 
State' on the bottom, and put a NOTE above them all that explains as much.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32837/#review82206
-----------------------------------------------------------


On April 30, 2015, 11:43 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32837/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 11:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Cody Maloney, and Michael Park.
> 
> 
> Bugs: MESOS-1991
>     https://issues.apache.org/jira/browse/MESOS-1991
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prep for unrestricted union Option<T>.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02 
> 
> Diff: https://reviews.apache.org/r/32837/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to