> On April 23, 2015, 7:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> >     nit: `s/template<>/template <>/`
> 
> Alexander Rojas wrote:
>     I was checking and all the entries in this file have the from 
> `template<>` should I change them all?
> 
> Michael Park wrote:
>     Yes please!
> 
> Alexander Rojas wrote:
>     Fix in review [33730](https://reviews.apache.org/r/33730/)

Discarded the fix because this patch no longer modifies anything in that file, 
now it stands as a standalone patch at 
[33733](https://reviews.apache.org/r/33733/).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------


On May 1, 2015, 12:39 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 12:39 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2620
>     https://issues.apache.org/jira/browse/MESOS-2620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a 
>   src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90 
>   src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd 
>   src/messages/flags.hpp PRE-CREATION 
>   src/messages/flags.proto PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
>   src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2 
> 
> Diff: https://reviews.apache.org/r/33296/diff/
> 
> 
> Testing
> -------
> 
> make check and manual tests.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to