> On May 26, 2015, 11:29 a.m., Joerg Schad wrote:
> > src/master/main.cpp, line 359
> > <https://reviews.apache.org/r/33296/diff/4/?file=946515#file946515line359>
> >
> >     we should whitelist emplace_back in the mesos styleguide

That goes again to the discussion whitelisting vs everything that is not 
mentioned is accepted. Though Ben mentioned that everything which is noe 
mentioned is whitelisted.


> On May 26, 2015, 11:29 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 243
> > <https://reviews.apache.org/r/33296/diff/4/?file=946519#file946519line243>
> >
> >     In order to be consistent with other flags (and removes the could): 
> > Either a JSON formatted string of rules or a file path....

This original wording using the word "could" is already consistent with outher 
flags, e.g. `acls`, `rate_limits`. The suggested wording is only used in 
`credentials` (Though it is used in both, master and slave).


> On May 26, 2015, 11:29 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 245
> > <https://reviews.apache.org/r/33296/diff/4/?file=946519#file946519line245>
> >
> >     s/could/must

Just as above, "could" is the prefered word for `whitelist`, `credentials`, 
`acls` and `rate_limits`, although modules use the alternative "can".


> On May 26, 2015, 11:29 a.m., Joerg Schad wrote:
> > src/master/flags.cpp, line 258
> > <https://reviews.apache.org/r/33296/diff/4/?file=946514#file946514line258>
> >
> >     see comment at slave flags

See below.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review85158
-----------------------------------------------------------


On June 1, 2015, 5:54 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2620
>     https://issues.apache.org/jira/browse/MESOS-2620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 4aeb4adef15a758d197fbf519d5e37ee04c33d87 
>   src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241 
>   src/master/flags.hpp 84fa238e5d61731c157b05f7935392dd375d9938 
>   src/master/flags.cpp 49d953a4d2387fa2e28e594988df993762de86df 
>   src/master/main.cpp d5666bc8ee8d7a0f0b8685f76d65dd1f9ac2a280 
>   src/messages/flags.hpp PRE-CREATION 
>   src/messages/flags.proto PRE-CREATION 
>   src/slave/flags.hpp e84efc1db41204dbabdd7c02525c2235a9157b8b 
>   src/slave/flags.cpp 7f2e1e8b43ae21db5e17393cee33bf52bdc47399 
>   src/slave/main.cpp f762f5b06be74c391cbc336b2da28f8358952ba4 
> 
> Diff: https://reviews.apache.org/r/33296/diff/
> 
> 
> Testing
> -------
> 
> make check and manual tests.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to