> On April 23, 2015, 2:49 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/include/process/firewall.hpp, line 37 > > <https://reviews.apache.org/r/33295/diff/1/?file=933067#file933067line37> > > > > I forgot the verbally proposed name for this function, but maybe a > > negated result and the name `reject()` would fit better. > > Adam B wrote: > Somebody suggested just using the () operator, aka the "apply" operator.
As decided in the review meeting, the () operator is not a good idea since the implementors will be called from pointers which results in weird looking syntax, i.e. either `(*foo)(socket, request)` (which looks like a function pointer or a weird looking cast) or `foo->operator()(socket, request)`. Naming was also considered ok in the meeting. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review80582 ----------------------------------------------------------- On May 1, 2015, 7:12 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33295/ > ----------------------------------------------------------- > > (Updated May 1, 2015, 7:12 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff. > > > Bugs: MESOS-2620 > https://issues.apache.org/jira/browse/MESOS-2620 > > > Repository: mesos > > > Description > ------- > > Introduces the interface `FirewallRule` which will be matched against > incoming connections in order to allow them to be served or being blocked. > For details, check the [design > doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit). > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 8aab0593f296c7aae71289f9bd6cf3eb3578a721 > 3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 392c74df3e8a122aecd3633dffdeec4bcbd1f097 > 3rdparty/libprocess/src/process.cpp > 8ab0dbcd3e9b858244f1e67061897143204eada0 > 3rdparty/libprocess/src/tests/process_tests.cpp > b6c6c511cabc525516b55d38fc4f5f596a3d6517 > docs/powered-by-mesos.md 8a0fefd07ed430f2fc81f1f3b350d451b7fafca5 > > Diff: https://reviews.apache.org/r/33295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
