----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84473 -----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp <https://reviews.apache.org/r/33295/#comment135774> Do we use this doxygen style anywhere else? Could not find any occurence in c++ code. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/33295/#comment135780> are universal/rvalue refs allowed by our style guide? If so should we add it to the styleguide? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/33295/#comment135781> Is there another level? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/33295/#comment135778> does our styleguide allow universal/rvalues? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/33295/#comment135777> does our styleguide allow std::move? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/33295/#comment135779> the raw pointer is not introduced by you, but it feels weird to have such delete in a synchronized block. As said this is not an issue (for this review), but maybe we should discuss wrapping request into Owned/unique/shared. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/33295/#comment135775> s/Sets/Tests? docs/powered-by-mesos.md <https://reviews.apache.org/r/33295/#comment135773> Is that dropped by a rebase or by you? Same below - Joerg Schad On May 20, 2015, 6:39 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33295/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 6:39 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff. > > > Bugs: MESOS-2620 > https://issues.apache.org/jira/browse/MESOS-2620 > > > Repository: mesos > > > Description > ------- > > Introduces the interface `FirewallRule` which will be matched against > incoming connections in order to allow them to be served or being blocked. > For details, check the [design > doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit). > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 8aab0593f296c7aae71289f9bd6cf3eb3578a721 > 3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 392c74df3e8a122aecd3633dffdeec4bcbd1f097 > 3rdparty/libprocess/src/process.cpp > e3de3cd6b536aaaf59784360aed546512dd04dc9 > 3rdparty/libprocess/src/tests/process_tests.cpp > 67e582cc250a9767a389e2bd0cc68985477f3ffb > > Diff: https://reviews.apache.org/r/33295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
