----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152/#review83639 -----------------------------------------------------------
src/cli/execute.cpp <https://reviews.apache.org/r/34152/#comment134647> This needs to be updated. See src/slave/main.cpp for an appropriate error message. src/cli/execute.cpp <https://reviews.apache.org/r/34152/#comment134648> Instead of doing it this way, I would recommend doing it the way MasterDetector::create() does the URL parsing (see src/master/detector.cpp) for consistency. - Vinod Kone On May 13, 2015, 5:50 p.m., Tom Arnfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34152/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 5:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-2723 > https://issues.apache.org/jira/browse/MESOS-2723 > > > Repository: mesos > > > Description > ------- > > The mesos-execute cli tool does custom validation on the --master flag > to improve user error handling, but currently does not support ZooKeeper. > > > Diffs > ----- > > src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 > > Diff: https://reviews.apache.org/r/34152/diff/ > > > Testing > ------- > > Compiled and tested locally on a live cluster, with both ZooKeeper and > standalone host:port. > > > Thanks, > > Tom Arnfeld > >
