reviews
Thread
Date
Earlier messages
Later messages
Messages by Thread
Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build.
Andrei Sekretenko
Re: Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build.
Greg Mann
Re: Review Request 72556: Fixed setting LIBPROCESS_ALLOW_JEMALLOC in Linux cmake build.
Andrei Sekretenko
[GitHub] [mesos] asfgit closed pull request #363: CMake enable install module dependencies.
GitBox
Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Andrei Sekretenko
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Mesos Reviewbot
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Andrei Sekretenko
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Benjamin Mahler
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Andrei Sekretenko
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Benjamin Mahler
Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.
Mesos Reviewbot
Review Request 72547: Fixed missing protoc dependency of compiled protobufs.
Andrei Sekretenko
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Andrei Sekretenko
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Mesos Reviewbot
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Andrei Sekretenko
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Benjamin Mahler
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Andrei Sekretenko
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Andrei Sekretenko
Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Mesos Reviewbot
Review Request 72536: Added an example to illustarate installing mesos-tests.
Andrei Sekretenko
Re: Review Request 72536: Added documentation for installing mesos-tests.
Andrei Sekretenko
Re: Review Request 72536: Added documentation for installing mesos-tests.
Greg Mann
Review Request 72535: Added a usage example for cmake install target into docs.
Andrei Sekretenko
Re: Review Request 72535: Added documentation for the cmake install target.
Andrei Sekretenko
Re: Review Request 72535: Added documentation for the cmake install target.
Greg Mann
[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`.
Qian Zhang
Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`.
Mesos Reviewbot
Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`.
Mesos Reviewbot
Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`.
Andrei Budnik
[GitHub] [mesos] Digital-Chaos opened a new pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] bmahler commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] Digital-Chaos commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] bmahler commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] bmahler closed pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] Digital-Chaos edited a comment on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] Digital-Chaos commented on pull request #365: Fix FreeBSD memory detection (MESOS-10104)
GitBox
[GitHub] [mesos] csaltos opened a new pull request #364: Fixing Java doc for JDK11
GitBox
[GitHub] [mesos] csaltos commented on pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11
GitBox
[GitHub] [mesos] cf-natali commented on pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11
GitBox
[GitHub] [mesos] qianzhangxa commented on pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11
GitBox
[GitHub] [mesos] qianzhangxa commented on pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11
GitBox
[GitHub] [mesos] qianzhangxa closed pull request #364: MESOS-10129 Build fails on Maven javadoc generation when using JDK11
GitBox
Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Qian Zhang
Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Mesos Reviewbot
Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Andrei Budnik
Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Qian Zhang
Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Qian Zhang
Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Andrei Budnik
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree.
Andrei Sekretenko
Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree.
Mesos Reviewbot
Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree.
Andrei Sekretenko
Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree.
Benjamin Mahler
Re: Review Request 72509: Got rid of tracking reserved offered/allocated in roles tree.
Mesos Reviewbot
Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree.
Andrei Sekretenko
Re: Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree.
Benjamin Mahler
Re: Review Request 72508: Fixed performance of tracking resource totals in allocator's roles tree.
Andrei Sekretenko
[GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
[GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies.
GitBox
Review Request 72494: Added tests to cmake install target.
Andrei Sekretenko
Re: Review Request 72494: Added tests to cmake install target.
Greg Mann
Re: Review Request 72494: Added tests to cmake install target.
Andrei Sekretenko
Re: Review Request 72494: Added tests to cmake install target.
Greg Mann
Review Request 72492: Introduced install target into cmake build.
Andrei Sekretenko
Re: Review Request 72492: Introduced install target into cmake build.
Greg Mann
Re: Review Request 72492: Introduced install target into cmake build.
Andrei Sekretenko
Re: Review Request 72492: Introduced install target into cmake build.
Greg Mann
Re: Review Request 72492: Introduced install target into cmake build.
Andrei Sekretenko
Re: Review Request 72492: Introduced install target into cmake build.
Greg Mann
Re: Review Request 72492: Introduced install target into cmake build.
Andrei Sekretenko
Re: Review Request 72492: Introduced install target into cmake build.
Greg Mann
Re: Review Request 72492: Introduced install target into cmake build.
Andrei Sekretenko
Re: Review Request 72492: Introduced install target into cmake build.
Greg Mann
Review Request 72493: Added install target into libprocess cmake build.
Andrei Sekretenko
Re: Review Request 72493: Added install target into libprocess cmake build.
Greg Mann
Re: Review Request 72493: Added install target into libprocess cmake build.
Andrei Sekretenko
Re: Review Request 72493: Added install target into libprocess cmake build.
Andrei Sekretenko
Re: Review Request 72493: Added install target into libprocess cmake build.
Greg Mann
Review Request 72496: Added install targets for Java libraries.
Andrei Sekretenko
Re: Review Request 72496: Added install targets for Java libraries.
Mesos Reviewbot
Review Request 72495: Added Web UI install target.
Andrei Sekretenko
Re: Review Request 72495: Added Web UI install target.
Greg Mann
Review Request 72478: Changed permissions for domain sockets to allow non-root executors.
Andrei Budnik
Re: Review Request 72478: Changed permissions for domain sockets to allow non-root executors.
Mesos Reviewbot
Re: Review Request 72478: Changed permissions for domain sockets to allow non-root executors.
Qian Zhang
Re: Review Request 71300: Removed mesos-style transition script.
Andrei Sekretenko
Re: Review Request 71300: Removed mesos-style transition script.
Benjamin Bannier
Review Request 72475: Added log message in executor's `disconnected` method before shutdown.
Andrei Budnik
Re: Review Request 72475: Added log message in executor's `disconnected` method before shutdown.
Mesos Reviewbot
Re: Review Request 72475: Logged connection error message before shutting down the executor.
Andrei Budnik
Re: Review Request 72475: Logged connection error message before shutting down the executor.
Qian Zhang
Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.
Andrei Sekretenko
Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.
Benjamin Mahler
Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.
Mesos Reviewbot
[GitHub] [mesos] cf-natali opened a new pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] vinodkone commented on pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] cf-natali commented on a change in pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] cf-natali commented on a change in pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
[GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY.
GitBox
Review Request 72461: WIP: Fixed cmd.exe handling in Subprocess.
Benjamin Mahler
Re: Review Request 72461: WIP: Fixed cmd.exe handling in Subprocess.
Mesos Reviewbot
Review Request 72460: WIP: Fixed Windows cmd.exe handling in stout's shell.hpp.
Benjamin Mahler
Review Request 72456: Removed unecessary os::execlp wrapper.
Benjamin Mahler
Re: Review Request 72456: Removed unecessary os::execlp wrapper.
Greg Mann
Review Request 72449: Kept resource limits in the `Container` struct in Docker containerizer.
Qian Zhang
Re: Review Request 72449: Kept resource limits in the `Container` struct in Docker containerizer.
Qian Zhang
Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Mesos Reviewbot
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Mesos Reviewbot
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Mesos Reviewbot
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72448: Fixed operator api event inconsistencies issue.
Andrei Sekretenko
Review Request 72445: Fixed operator api event inconsistencies issue.
Dong Zhu
Re: Review Request 72445: Fixed operator api event inconsistencies issue.
Mesos Reviewbot
Re: Review Request 72445: Fixed operator api event inconsistencies issue.
Dong Zhu
Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Qian Zhang
Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Mesos Reviewbot
Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Andrei Budnik
Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Greg Mann
Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Qian Zhang
Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.
Qian Zhang
[GitHub] [mesos] akornatskyy opened a new pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.
GitBox
[GitHub] [mesos] akornatskyy commented on pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.
GitBox
[GitHub] [mesos] greggomann commented on a change in pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.
GitBox
[GitHub] [mesos] greggomann commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.
GitBox
[GitHub] [mesos] akornatskyy commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.
GitBox
[GitHub] [mesos] akornatskyy opened a new pull request #360: Fix java bindings.
GitBox
[GitHub] [mesos] akornatskyy commented on pull request #360: Fix java bindings.
GitBox
Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.
Qian Zhang
Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.
Mesos Reviewbot
Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.
Greg Mann
Review Request 72428: Added intermediate OBJECT library targets for libprocess.
Andrei Sekretenko
Re: Review Request 72428: Added intermediate OBJECT library targets for libprocess.
Mesos Reviewbot
Review Request 72427: Added intermediate OBJECT library targets for mesos.
Andrei Sekretenko
Review Request 72426: Added workaround for broken transitive dependencies into stout's cmake.
Andrei Sekretenko
Review Request 72413: Updated executor API docs to include the domain socket.
Greg Mann
Re: Review Request 72413: Updated executor API docs to include the domain socket.
Mesos Reviewbot
Re: Review Request 72413: Updated executor API docs to include the domain socket.
Vinod Kone
Re: Review Request 72413: Updated executor API docs to include the domain socket.
Benjamin Mahler
Re: Review Request 72413: Updated executor API docs to include the domain socket.
Greg Mann
Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Mesos Reviewbot
Re: Review Request 72410: Updated existing documentation for resource limits.
Qian Zhang
Re: Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Tim Harper
Re: Review Request 72410: Updated existing documentation for resource limits.
Tim Harper
Re: Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Mesos Reviewbot
Re: Review Request 72410: Updated existing documentation for resource limits.
Qian Zhang
Re: Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Mesos Reviewbot
Re: Review Request 72410: Updated existing documentation for resource limits.
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource limits.
Qian Zhang
Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Earlier messages
Later messages