----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83700 -----------------------------------------------------------
Ship it! src/slave/resource_estimator.hpp <https://reviews.apache.org/r/33919/#comment134742> Do you still need this include? src/slave/resource_estimator.cpp <https://reviews.apache.org/r/33919/#comment134745> You don't need an else block here src/slave/slave.hpp <https://reviews.apache.org/r/33919/#comment134746> Let's make these private (if possible) :) - Niklas Nielsen On May 13, 2015, 5:07 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33919/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 5:07 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > Integrated resources estimator with the slave. > > This patch hooks the resources estimator with the slave. Slave will simply > forward the estimation from the resources estimator to the master. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp PRE-CREATION > src/Makefile.am 5b2c6014dde64a5f29986b375209de85187482a4 > src/local/local.cpp dda25ab348c6430360c4b88e1d93dc70d14738d2 > src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 > src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec > src/slave/constants.cpp 2a99b1105af0e2d62b956fa96988f477937a46bd > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2 > src/slave/resource_estimator.hpp PRE-CREATION > src/slave/resource_estimator.cpp PRE-CREATION > src/slave/slave.hpp adb52b587ae151a51cf21ebd4923aaec1548ef10 > src/slave/slave.cpp 1b17441d7153f25bd16e6b1d863ddca265480eb5 > src/tests/cluster.hpp 95061665974a7aca98c374735dd9520278d89043 > src/tests/mesos.hpp 563b833f8563ee6687ef95143815ed38dff71657 > src/tests/mesos.cpp bc082e8d91deb2c5dd64bbc3f0a8a50fa7d19264 > src/tests/oversubscription_tests.cpp PRE-CREATION > src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6 > > Diff: https://reviews.apache.org/r/33919/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
