> On May 7, 2015, 2:18 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3970-3973 > > <https://reviews.apache.org/r/33919/diff/1/?file=951659#file951659line3970> > > > > It seems easier if we just use a no-op estimator when oversubscription > > is disabled, rather than special casing it in the slave, no? > > > > Is there not an interplay here between this flag and another flag for > > which estimator to use? Maybe we need one flag? E.g. > > > > ``` > > --oversubscription=disable <-- this for disabling > > --oversubscription=conservative > > --oversubscription=bayesian > > --oversubscription=custom > > ``` > > > > Did you have something in mind for exposing this?
Wouldn't this be a consequence of selecting certain estimators and qos controllers? Should it be some kind of "oversubscription profile" which selects those? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review82912 ----------------------------------------------------------- On May 6, 2015, 3:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33919/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 3:35 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > Integrated resources estimator with the slave. > > This patch hooks the resources estimator with the slave. Slave will simply > forward the estimation from the resources estimator to the master. > > > Diffs > ----- > > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > src/slave/slave.hpp 654a8698be88e0d0f588190775dc3eee6b36f92e > src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 > src/tests/oversubscription_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33919/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
