----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review83825 -----------------------------------------------------------
src/slave/containerizer/provisioners/appc/discovery.hpp <https://reviews.apache.org/r/34139/#comment134902> How about namespacing this under appc as well? mesos::internal::slave::Discovery seems pretty generic to me. src/slave/containerizer/provisioners/appc/discovery.cpp <https://reviews.apache.org/r/34139/#comment134903> static? src/slave/containerizer/provisioners/appc/discovery.cpp <https://reviews.apache.org/r/34139/#comment134904> Can you print the unsupported strategy? src/slave/flags.cpp <https://reviews.apache.org/r/34139/#comment134900> Do you think we should namespace these flags with appc? Seems like appc so far is the only one that has a configurable discvoery mechanism and local dir - Timothy Chen On May 13, 2015, 12:47 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34139/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 12:47 a.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Local and simple discovery only. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/provisioners/appc/discovery.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > > Diff: https://reviews.apache.org/r/34139/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
