----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84003 -----------------------------------------------------------
Looks good. My main comments are around naming. include/mesos/slave/resource_estimator.hpp <https://reviews.apache.org/r/34299/#comment135109> s/estimation about/estimation of/ include/mesos/slave/resource_estimator.hpp <https://reviews.apache.org/r/34299/#comment135110> s/oversubscribed/oversubscribable/ ? or s/oversubscribed/oversubscribe/ because these are not resources that are already oversubscribed? src/slave/slave.hpp <https://reviews.apache.org/r/34299/#comment135118> I would actually s/receive/update/ s/update/send/ src/slave/slave.hpp <https://reviews.apache.org/r/34299/#comment135120> Make this optional, so that slave will only send an update after the first estimate is received? src/slave/slave.cpp <https://reviews.apache.org/r/34299/#comment135124> s/update/send/ src/slave/slave.cpp <https://reviews.apache.org/r/34299/#comment135123> LOG(INFO) << "Sending oversubscribed resources " << oversubscribedResources; src/slave/slave.cpp <https://reviews.apache.org/r/34299/#comment135127> s/Update// src/slave/slave.cpp <https://reviews.apache.org/r/34299/#comment135128> s/update_// src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34299/#comment135130> s/UpdateOversubcribedResourcesMessage/SendOversubscribedResources/ src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34299/#comment135131> s/estimation/estimation of oversubscribed resources/ - Vinod Kone On May 15, 2015, 11:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34299/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 11:38 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2735 > https://issues.apache.org/jira/browse/MESOS-2735 > > > Repository: mesos > > > Description > ------- > > Changed to use a push model for resource estimator. See ticket for details. > > This patch also makes the interval configurable through slave flags. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp > 363961541c9b49763e8cbafe982421d45516db0d > src/slave/constants.hpp df02043fcd1b5bffc13aa0683ad9b64372188300 > src/slave/constants.cpp 07f699a9e5c1b56d6e0435077823ad0f863ad63c > src/slave/flags.hpp ca7cc131f70d58982262fd29986d46877d563035 > src/slave/flags.cpp f35c76a342d03700710bb91bf4c523cc99769228 > src/slave/resource_estimator.hpp bdf62bab9b632aa16801e47978962a7ab24b53b4 > src/slave/resource_estimator.cpp 13d706c30d36c9f304acf288f02d6c9558bac781 > src/slave/slave.hpp b62ed7b207fa337027baffa1c75139641a41dad6 > src/slave/slave.cpp 132f83e05dd4113c8f6d20a6a64b12fb8f05dd36 > src/tests/mesos.hpp df8cd200a6970209588b63a1d58709b1f913a305 > src/tests/oversubscription_tests.cpp > 64c2ede1f50546f6de1ecb2972036b51fe17e358 > > Diff: https://reviews.apache.org/r/34299/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
