-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34299/#review84187
-----------------------------------------------------------


There are still places where it says "oversubscribed". I pointed to some here. 
Please do a sweep to catch everything.


src/slave/flags.hpp
<https://reviews.apache.org/r/34299/#comment135313>

    s/oversubscribed/oversubscribe/ ?



src/slave/flags.cpp
<https://reviews.apache.org/r/34299/#comment135314>

    s/oversubscribed/oversubscribe/ ?



src/slave/slave.cpp
<https://reviews.apache.org/r/34299/#comment135319>

    Looking at how we did status update forwarding, maybe s/send/forward/ ? 
sorry, didn't catch this earlier.



src/slave/slave.cpp
<https://reviews.apache.org/r/34299/#comment135320>

    s/Sending/Forwarding/
    
    s/oversubscribed/oversubscribable/



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34299/#comment135321>

    s/oversubscribed/oversubscribable/



src/messages/messages.proto
<https://reviews.apache.org/r/34299/#comment135312>

    s/Oversubscribed/Oversubscribe/ ?


- Vinod Kone


On May 18, 2015, 5:58 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34299/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2735
>     https://issues.apache.org/jira/browse/MESOS-2735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed to use a push model for resource estimator. See ticket for details.
> 
> This patch also makes the interval configurable through slave flags.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/resource_estimator.hpp 
> 363961541c9b49763e8cbafe982421d45516db0d 
>   src/messages/messages.proto 19e244453577dc7147352ee94d99107a8a0a1d68 
>   src/slave/constants.hpp df02043fcd1b5bffc13aa0683ad9b64372188300 
>   src/slave/constants.cpp 07f699a9e5c1b56d6e0435077823ad0f863ad63c 
>   src/slave/flags.hpp ca7cc131f70d58982262fd29986d46877d563035 
>   src/slave/flags.cpp da30973ce31377532dc6ee2f4bd66e4325f9d381 
>   src/slave/resource_estimator.hpp bdf62bab9b632aa16801e47978962a7ab24b53b4 
>   src/slave/resource_estimator.cpp 13d706c30d36c9f304acf288f02d6c9558bac781 
>   src/slave/slave.hpp b62ed7b207fa337027baffa1c75139641a41dad6 
>   src/slave/slave.cpp 132f83e05dd4113c8f6d20a6a64b12fb8f05dd36 
>   src/tests/mesos.hpp df8cd200a6970209588b63a1d58709b1f913a305 
>   src/tests/oversubscription_tests.cpp 
> 64c2ede1f50546f6de1ecb2972036b51fe17e358 
> 
> Diff: https://reviews.apache.org/r/34299/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to