----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258/#review84089 -----------------------------------------------------------
Patch looks great! Reviews applied: [34256, 34259, 34260, 34258] All tests passed. - Mesos ReviewBot On May 17, 2015, 10:58 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34258/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 10:58 p.m.) > > > Review request for mesos and Cody Maloney. > > > Bugs: MESOS-1303 > https://issues.apache.org/jira/browse/MESOS-1303 > > > Repository: mesos-incubating > > > Description > ------- > > os::dirname and os::basename were not thread safe on OSX. Replacements are > path::dirname and path::basename. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/README.md 588f739 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be > > Diff: https://reviews.apache.org/r/34258/diff/ > > > Testing > ------- > > make check on trailing RR. > > > Thanks, > > Till Toenshoff > >
