----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258/#review86814 -----------------------------------------------------------
Bad patch! Reviews applied: [34256, 35131, 34259, 34260] Failed command: ./support/apply-review.sh -n -r 34260 Error: 2015-06-05 16:47:17 URL:https://reviews.apache.org/r/34260/diff/raw/ [23611/23611] -> "34260.patch" [1] error: patch failed: src/cli/mesos.cpp:28 error: src/cli/mesos.cpp: patch does not apply error: patch failed: src/examples/low_level_scheduler_libprocess.cpp:345 error: src/examples/low_level_scheduler_libprocess.cpp: patch does not apply error: patch failed: src/examples/low_level_scheduler_pthread.cpp:403 error: src/examples/low_level_scheduler_pthread.cpp: patch does not apply error: patch failed: src/examples/test_framework.cpp:32 error: src/examples/test_framework.cpp: patch does not apply error: patch failed: src/launcher/executor.cpp:633 error: src/launcher/executor.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On June 5, 2015, 4:39 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34258/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 4:39 p.m.) > > > Review request for mesos and Cody Maloney. > > > Bugs: MESOS-1303 > https://issues.apache.org/jira/browse/MESOS-1303 > > > Repository: mesos-incubating > > > Description > ------- > > os::dirname and os::basename were not thread safe on OSX. Replacements are > path::dirname and path::basename. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/README.md 588f739 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be > > Diff: https://reviews.apache.org/r/34258/diff/ > > > Testing > ------- > > make check on trailing RR. > > > Thanks, > > Till Toenshoff > >
