> On May 18, 2015, 5:48 p.m., Marco Massenzio wrote:
> > src/examples/test_hook_module.cpp, lines 36-38
> > <https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36>
> >
> >     Thanks for doing this!
> >     
> >     I'm wondering whether, as these are constants, shouldn't they be in 
> > `SCREAMING_SNAKE_CASE` as per the [Style 
> > Guide](http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/)?
> >     
> >     I completely realize that the existing code (lines above) does not 
> > follow this style, so I'm really wondering whether that was by design or 
> > accident?
> >     
> >     And, if the latter, would this be also a good time to fix those too?
> >     
> >     No matter what, though, this is A Good Thing.

I'd be fine converting the other constants too, I guess just waiting on 
somebody saying if it was intentional or not.


- Colin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34361/#review84172
-----------------------------------------------------------


On May 18, 2015, 5:01 p.m., Colin Williams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34361/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2637
>     https://issues.apache.org/jira/browse/MESOS-2637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> converted hard-coded strings to consts
> 
> 
> Diffs
> -----
> 
>   src/examples/test_hook_module.cpp b25830ab6475f997422cfd2f60cc9a79e1acadfe 
>   src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
>   src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 
> 
> Diff: https://reviews.apache.org/r/34361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Williams
> 
>

Reply via email to