----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34571/#review84817 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/34571/#comment136208> This is a protocol between slave and the QoSController, both of which are internal to Mesos. So we probably should move this message definition to src/messages/messages.proto. include/mesos/mesos.proto <https://reviews.apache.org/r/34571/#comment136212> It reads weired when one wants to create a QoS correction (too many words 'correction'): ``` QoSCorrections::Correction correction; ``` How about we just define the `QoSCorrection` message and create a wrapper class `QoSCorrections` in C++ (similar to what we did for `Resource`)? include/mesos/mesos.proto <https://reviews.apache.org/r/34571/#comment136210> I liked Niklas's suggestion. How about following the style used by Offer.Operation. Also, Let's try not to introduce those fields that are unneeded right now. ``` message QoSCorrection { enum Type { KILL = 1; } message Kill { required ContainerID container_id = 1; } required Type type = 1; optional Kill kill = 2; } ``` - Jie Yu On May 21, 2015, 11:02 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34571/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:02 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2760 > https://issues.apache.org/jira/browse/MESOS-2760 > > > Repository: mesos > > > Description > ------- > > This part of proto describes a QoS corrections message which includes > corrections for particular executors or tasks. > It is a generic message between QoS Controller and slave. > > > Diffs > ----- > > include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 > > Diff: https://reviews.apache.org/r/34571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
