> On May 21, 2015, 4:24 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1189 > > <https://reviews.apache.org/r/34571/diff/1/?file=968376#file968376line1189> > > > > This is a protocol between slave and the QoSController, both of which > > are internal to Mesos. So we probably should move this message definition > > to src/messages/messages.proto. > > Niklas Nielsen wrote: > We need this to be public to make QoS Controller modules :) > > Jie Yu wrote: > ah. Then how about creating a new proto file > > include/mesos/slave/oversubscription.proto
I like it! - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34571/#review84817 ----------------------------------------------------------- On May 21, 2015, 4:02 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34571/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 4:02 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2760 > https://issues.apache.org/jira/browse/MESOS-2760 > > > Repository: mesos > > > Description > ------- > > This part of proto describes a QoS corrections message which includes > corrections for particular executors or tasks. > It is a generic message between QoS Controller and slave. > > > Diffs > ----- > > include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 > > Diff: https://reviews.apache.org/r/34571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
