> On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: > > Thanks a lot for this, Stan - much appreciated! > > > > There are a couple of style nits here and there and one basic question on > > the need of the `read`-variant for Solaris. > > > > For submitting an updated patch, please consult the patch submission > > guidelines http://mesos.apache.org/documentation/latest/submitting-a-patch/ > > specifically after "Submit your patch" - we need a patch that can be > > processed using our tooling and for that to work, an easy way is to follow > > that guide.
Followed the guide and on git commit to the local branch I got a couple of more style recommendations which I fixed: git commit -m "stout library - added support for Solaris" Checking 5 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp:80: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:110: Lines should be <= 80 characters long [whitespace/line_length] [2] Total errors found: 2 But next step failed: $ support/post-reviews.py Running 'rbt post' across all of ... dbce4005a99e919fd0deaffda76e2e91fc63ade0 - (HEAD, solaris) stout library - added support for Solaris (10 minutes ago) Creating diff of: dbce4005a99e919fd0deaffda76e2e91fc63ade0 - (HEAD, solaris) stout library - added support for Solaris ... with parent diff created from: Press enter to continue or 'Ctrl-C' to skip. Failed to execute: 'rbt post --repository-url=git://git.apache.org/mesos.git --tracking-branch=master master dbce4005a99e919fd0deaffda76e2e91fc63ade0': CRITICAL: object of type 'NoneType' has no len() - Stan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84202 ----------------------------------------------------------- On May 19, 2015, 12:21 a.m., Stan Teresen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34268/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 12:21 a.m.) > > > Review request for mesos, Joris Van Remoortere and Till Toenshoff. > > > Repository: mesos-incubating > > > Description > ------- > > stout library - adding support for Solaris > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be > 3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 86949ec > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp b0ed5cc > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 81d64cc > > Diff: https://reviews.apache.org/r/34268/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > adding missing new file: stout/os/sunos.hpp > > https://reviews.apache.org/media/uploaded/files/2015/05/15/a2e296fa-e251-4467-9873-77d8ced7f0a3__sunos.hpp > > > Thanks, > > Stan Teresen > >
