----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review85719 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp <https://reviews.apache.org/r/34268/#comment137463> Seems we got some options here; A. use your separate, stream-based approach for solaris. B. use your separate, stream-based approach for all systems. C. re-implement getline within stout for solaris (e.g. http://opensource.apple.com/source/cvs/cvs-29/cvs/lib/getline.c) Option A. feels a bit weird as it presents a solution that should work on all systems, so why bother with alternatives - but see B :). Option B. Using streams has the nimbus of being slow - I have no prove at hand but that concern already got raised when I discussed your approach with a team-mate. Option C. Feels just right to me also because in the future, we may encounter more systems lacking of those GNU C extensions. What do you think, could we go for C. in your patch? We could also pick A. for now and add a comment (TODO) proposing Option C. to get implemented as soon as other systems with the lack of GNU C extensions are to be supported. - Till Toenshoff On May 22, 2015, 7:15 p.m., Stan Teresen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34268/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 7:15 p.m.) > > > Review request for mesos, Joris Van Remoortere and Till Toenshoff. > > > Repository: mesos-incubating > > > Description > ------- > > stout library - adding support for Solaris > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be > 3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 86949ec > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp b0ed5cc > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 81d64cc > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34268/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > adding missing new file: stout/os/sunos.hpp > > https://reviews.apache.org/media/uploaded/files/2015/05/15/a2e296fa-e251-4467-9873-77d8ced7f0a3__sunos.hpp > > > Thanks, > > Stan Teresen > >