----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review85096 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/29889/#comment136568> Ah, I realize why now I want a promise. So the semantics I want to have is that I want to able to propagate the failure from run back out to the caller, so that it shows up in the TaskStatus update, but otherwise return the inspect future when it succeed. So I do want to use the promise associate to handle both cases. I'll leave a comment. - Timothy Chen On May 23, 2015, 6:14 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29889/ > ----------------------------------------------------------- > > (Updated May 23, 2015, 6:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2115 > https://issues.apache.org/jira/browse/MESOS-2115 > > > Repository: mesos > > > Description > ------- > > This is a one mega patch and contains many reviews that's already on rb. > > This review is not meant to be merged, only provided for easier review. > > > Diffs > ----- > > Dockerfile 35abf25 > docs/configuration.md 54c4e31 > docs/docker-containerizer.md a5438b7 > src/Makefile.am 34755cf > src/docker/docker.hpp 3ebbc1f > src/docker/docker.cpp 3a485a2 > src/docker/executor.hpp PRE-CREATION > src/docker/executor.cpp PRE-CREATION > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/containerizer/docker.hpp ed4ee19 > src/slave/containerizer/docker.cpp 408a443 > src/slave/flags.hpp 5c57478 > src/slave/flags.cpp b5e2518 > src/tests/docker_containerizer_tests.cpp 154bf98 > src/tests/docker_tests.cpp 5520c58 > > Diff: https://reviews.apache.org/r/29889/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
