reviews
Thread
Date
Earlier messages
Later messages
Messages by Thread
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Benjamin Mahler
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Review Request 72820: Relaxed unknown volume check when unpublishing volumes.
Qian Zhang
Re: Review Request 72820: Relaxed unknown volume check when unpublishing volumes.
Greg Mann
Review Request 72816: Fixed broken authorization in the CSI server.
Greg Mann
Re: Review Request 72816: Fixed broken authorization in the CSI server.
Qian Zhang
Re: Review Request 72816: Fixed broken authorization in the CSI server.
Greg Mann
Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Mesos Reviewbot
Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Mesos Reviewbot
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Qian Zhang
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Qian Zhang
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery.
Qian Zhang
Review Request 72805: Added a test helper for CSI volumes.
Greg Mann
Re: Review Request 72805: Added a test helper for CSI volumes.
Qian Zhang
Re: Review Request 72805: Added a test helper for CSI volumes.
Greg Mann
Re: Review Request 72805: Added a test helper for CSI volumes.
Greg Mann
Re: Review Request 72805: Added a test helper for CSI volumes.
Qian Zhang
Review Request 72803: Added a new agent flag `--csi_volume_chown`.
Qian Zhang
Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Mesos Reviewbot
Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Greg Mann
Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.
Greg Mann
Re: Review Request 72804: Enabled CSI volume access for non-root users.
Qian Zhang
Review Request 72799: Fixed a data race in the CSI server.
Greg Mann
Re: Review Request 72799: Fixed a bug in CSI server initialization.
Greg Mann
Re: Review Request 72799: Fixed a bug in CSI server initialization.
Qian Zhang
Re: Review Request 72799: Fixed a bug in CSI server initialization.
Greg Mann
Review Request 72794: Added a test for discarding image pull on discard of getting image.
Andrei Sekretenko
Re: Review Request 72794: Added a test for discarding image pull on discard of getting image.
Mesos Reviewbot
Re: Review Request 72794: Added a test for discarding image pull on discard of getting image.
Qian Zhang
Review Request 72793: Added discarding a future returned by get() into the docker store test.
Andrei Sekretenko
Re: Review Request 72793: Added discarding a future returned by get() into the docker store test.
Qian Zhang
Review Request 72792: Fixed typos in the name of `PullingSameImageSimutanuously` test.
Andrei Sekretenko
Re: Review Request 72792: Fixed typos in the name of `PullingSameImageSimutanuously` test.
Qian Zhang
Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test.
Andrei Sekretenko
Re: Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test.
Qian Zhang
Review Request 72790: Deduplicated concurrent image pulls by docker store.
Andrei Sekretenko
Re: Review Request 72790: Deduplicated concurrent image pulls by docker store.
Qian Zhang
Re: Review Request 72790: Deduplicated concurrent image pulls by docker store.
Andrei Sekretenko
Review Request 72789: Checkpointed CSI volume state in stringified JSON.
Qian Zhang
Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON.
Qian Zhang
Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON.
Mesos Reviewbot
Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON.
Greg Mann
Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Qian Zhang
Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Qian Zhang
Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Qian Zhang
Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Mesos Reviewbot
Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.
Greg Mann
Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator.
Qian Zhang
Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator.
Qian Zhang
Review Request 72788: Added a work around in v1 volume manager for Portworx CSI plugin.
Qian Zhang
Re: Review Request 72788: Added a work around in v1 volume manager for Portworx CSI plugin.
Mesos Reviewbot
Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.
Qian Zhang
Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.
Mesos Reviewbot
Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.
Greg Mann
Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.
Qian Zhang
Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72786: Implemented regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72786: Implemented regex-based offer constraints.
Andrei Sekretenko
Review Request 72787: Added basic tests for regexp-based constraints.
Andrei Sekretenko
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Andrei Sekretenko
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Benjamin Mahler
Re: Review Request 72787: Added basic tests for regexp-based constraints.
Mesos Reviewbot
Review Request 72782: Added RE2 to the CMake build.
Andrei Sekretenko
Re: Review Request 72782: Added RE2 to the CMake build.
Andrei Sekretenko
Re: Review Request 72782: Added RE2 to the CMake build.
Benjamin Mahler
Review Request 72784: Added protobuf messages for regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Andrei Sekretenko
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Benjamin Mahler
Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.
Andrei Sekretenko
Review Request 72785: Introduced a weak_ptr-based cache abstraction.
Andrei Sekretenko
Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.
Mesos Reviewbot
Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.
Mesos Reviewbot
Review Request 72783: Added RE2 to the automake build.
Andrei Sekretenko
Re: Review Request 72783: Added RE2 to the automake build.
Andrei Sekretenko
Re: Review Request 72783: Added RE2 to the automake build.
Benjamin Mahler
Review Request 72781: Updated volume manager to support user specified target path root.
Qian Zhang
Re: Review Request 72781: Updated volume manager to support user specified target path root.
Mesos Reviewbot
Re: Review Request 72781: Updated volume manager to support user specified target path root.
Greg Mann
Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Qian Zhang
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Mesos Reviewbot
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Re: Review Request 72779: Initialized plugins lazily in the CSI server.
Greg Mann
Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Andrei Sekretenko
Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Mesos Reviewbot
Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Andrei Sekretenko
Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Andrei Sekretenko
Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Benjamin Mahler
Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.
Andrei Sekretenko
Review Request 72775: Implemented offer constraints on a string attribute equality.
Andrei Sekretenko
Re: Review Request 72775: Implemented offer constraints on a string attribute equality.
Andrei Sekretenko
Re: Review Request 72775: Implemented offer constraints on a string attribute equality.
Benjamin Mahler
Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Benjamin Mahler
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Benjamin Mahler
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Benjamin Mahler
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Andrei Sekretenko
Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.
Benjamin Mahler
Review Request 72743: Wired up creating `OfferConstraintsFilter` into the schdeuler API.
Andrei Sekretenko
Re: Review Request 72743: Wired up creating `OfferConstraintsFilter` into the schdeuler API.
Benjamin Mahler
Re: Review Request 72743: Wired up creating `OfferConstraintsFilter` into the schdeuler API.
Andrei Sekretenko
Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator.
Andrei Sekretenko
Re: Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator.
Benjamin Mahler
Re: Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator.
Andrei Sekretenko
Review Request 72771: Removed `evolve(const scheduler::Call&)`.
Andrei Sekretenko
Re: Review Request 72771: Removed `evolve(const scheduler::Call&)`.
Benjamin Mahler
Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.
Qian Zhang
Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.
Mesos Reviewbot
Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.
Greg Mann
Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Qian Zhang
Re: Review Request 72761: Added the CSI server to the Mesos agent.
Greg Mann
Earlier messages
Later messages