reviews
Thread
Date
Earlier messages
Later messages
Messages by Thread
Re: Review Request 72955: Consolidated creation and validation of `allocator::Framework` options.
Andrei Sekretenko
Review Request 72953: Made the offer constraints filter non-optional inside the allocator.
Andrei Sekretenko
Re: Review Request 72953: Made the offer constraints filter non-optional inside the allocator.
Benjamin Mahler
Review Request 72954: Added suppressed roles to `allocator/offer_constraints_debug` endpoint.
Andrei Sekretenko
Re: Review Request 72954: Added suppressed roles to `allocator/offer_constraints_debug` endpoint.
Mesos Reviewbot
Re: Review Request 72954: Added suppressed roles to `allocator/offer_constraints_debug` endpoint.
Benjamin Mahler
Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.
Qian Zhang
Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.
Qian Zhang
Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.
Mesos Reviewbot
Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.
Benjamin Mahler
Re: Review Request 72945: Ignored directoy entries when globing Nvidia GPU devices.
Qian Zhang
[GitHub] [mesos] ntsvetanov opened a new pull request #369: Add mishmash io to powered-by-mesos.md
GitBox
[GitHub] [mesos] ntsvetanov commented on pull request #369: Add mishmash io to powered-by-mesos.md
GitBox
[GitHub] [mesos] bmahler merged pull request #369: Add mishmash io to powered-by-mesos.md
GitBox
Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Andrei Sekretenko
Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Mesos Reviewbot
Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Benjamin Mahler
Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Andrei Sekretenko
Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Andrei Sekretenko
Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Mesos Reviewbot
[GitHub] [mesos] jeremyvdw opened a new pull request #368: Updated Marathon in Mesos mini docker container
GitBox
Review Request 72901: WIP: Added setting offer constraints to the Java example framework.
Andrei Sekretenko
Re: Review Request 72901: WIP: Added setting offer constraints to the Java example framework.
Mesos Reviewbot
Re: Review Request 72901: WIP: Added setting offer constraints to the Java example framework.
Mesos Reviewbot
Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Benjamin Mahler
Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Review Request 72897: Allowed `OfferConstraintsFilter::create()` to return an empty `Result`.
Andrei Sekretenko
Re: Review Request 72897: Allowed `OfferConstraintsFilter::create()` to return an empty `Result`.
Benjamin Mahler
Re: Review Request 72897: Allowed `OfferConstraintsFilter::create()` to return an empty `Result`.
Andrei Sekretenko
Re: Review Request 72897: Allowed `OfferConstraintsFilter::create()` to return an empty `Result`.
Benjamin Mahler
Re: Review Request 72897: Made offer constraints filter and protobuf non-optional inside the code.
Andrei Sekretenko
Re: Review Request 72897: Made offer constraints filter and protobuf non-optional inside the code.
Benjamin Mahler
Re: Review Request 72897: Made offer constraints filter and protobuf non-optional inside the code.
Andrei Sekretenko
Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.
Andrei Sekretenko
Re: Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.
Andrei Sekretenko
Re: Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.
Andrei Sekretenko
Re: Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.
Benjamin Mahler
Review Request 72899: Added a test for creating a filter from default `OfferConstraints`.
Andrei Sekretenko
Re: Review Request 72899: Added a test for creating a filter from default `OfferConstraints`.
Andrei Sekretenko
Re: Review Request 72899: Added a test for creating a filter from default `OfferConstraints`.
Benjamin Mahler
Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.
Qian Zhang
Re: Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.
Qian Zhang
Re: Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.
Mesos Reviewbot
Re: Review Request 72888: Inferred CSI volume's `readonly` field from volume mode.
Greg Mann
Review Request 72885: Made the hierarchical allocator store `FrameworkInfo` internally.
Andrei Sekretenko
Re: Review Request 72885: Made the hierarchical allocator store `FrameworkInfo` internally.
Benjamin Mahler
Review Request 72886: Enforced explicit construction of `protobuf::...::Capabilities`.
Andrei Sekretenko
Re: Review Request 72886: Enforced explicit construction of `protobuf::...::Capabilities`.
Benjamin Mahler
Review Request 72887: Tied the hierarchical allocator process to a fixed process ID.
Andrei Sekretenko
Re: Review Request 72887: Tied the hierarchical allocator process to a fixed process ID.
Benjamin Mahler
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Andrei Sekretenko
Re: Review Request 72887: Tied the hierarchical allocator process to a fixed process ID.
Mesos Reviewbot
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Andrei Sekretenko
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Mesos Reviewbot
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Benjamin Mahler
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Benjamin Mahler
Re: Review Request 72887: Tied the 1st hierarchical allocator process to a process ID "allocator".
Andrei Sekretenko
Review Request 72877: WIP: Modified Java test framework to set offer constraints.
Andrei Sekretenko
Re: Review Request 72877: WIP: Modified Java test framework to set offer constraints.
Mesos Reviewbot
Review Request 72876: Added offer constraints to `updateFramework()` in the Java bindings.
Andrei Sekretenko
Review Request 72875: Consolidated protobuf construction by the JNI scheduler driver.
Andrei Sekretenko
Re: Review Request 72875: Consolidated protobuf construction by the JNI scheduler driver.
Benjamin Mahler
Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Andrei Sekretenko
Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Benjamin Mahler
Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Andrei Sekretenko
Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Andrei Sekretenko
Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.
Benjamin Mahler
Review Request 72864: Made `UpdateFrameworkTest.OfferConstraints` build constraints from JSON.
Andrei Sekretenko
Re: Review Request 72864: Made `UpdateFrameworkTest.OfferConstraints` build constraints from JSON.
Mesos Reviewbot
Re: Review Request 72864: Made `UpdateFrameworkTest.OfferConstraints` build constraints from JSON.
Benjamin Mahler
Review Request 72862: Added cleanup of build dir to website bot.
Vinod Kone
Re: Review Request 72862: Added cleanup of build dir to website bot.
Andrei Sekretenko
Review Request 72861: Added `--no-same-owner` option to tar command.
Vinod Kone
Re: Review Request 72861: Added `--no-same-owner` option to tar command.
Andrei Sekretenko
Review Request 72860: Added `--no-same-owner` option to tar command.
Vinod Kone
Re: Review Request 72860: Added `--no-same-owner` option to tar command.
Andrei Sekretenko
Review Request 72859: Added `--no-same-owner` option to tar command.
Vinod Kone
Re: Review Request 72859: Added `--no-same-owner` option to tar command.
Andrei Sekretenko
[GitHub] [mesos] Lqp1 opened a new pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] asekretenko commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] asfgit closed pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] asfgit closed pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
[GitHub] [mesos] Lqp1 commented on pull request #367: Expose hierarchical allocator recovery parameters as master flags
GitBox
Review Request 72858: Reduced build parallelism to avoid aborted builds in CI.
Vinod Kone
Re: Review Request 72858: Reduced build parallelism to avoid aborted builds in CI.
Andrei Sekretenko
Re: Review Request 72858: Reduced build parallelism to avoid aborted builds in CI.
Vinod Kone
Re: Review Request 72858: Reduced build parallelism to avoid aborted builds in CI.
Mesos Reviewbot
Review Request 72857: Merged build.sh and entrypoint.sh.
Vinod Kone
Re: Review Request 72857: Merged build.sh and entrypoint.sh.
Andrei Sekretenko
Review Request 72856: Fixed Website bot to work with docker user namespaces.
Vinod Kone
Re: Review Request 72856: Fixed Website bot to work with docker user namespaces.
Andrei Sekretenko
Re: Review Request 72856: Fixed Website bot to work with docker user namespaces.
Vinod Kone
Review Request 72851: Added an `/offer_constraints_debug` endpoint.
Andrei Sekretenko
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Andrei Sekretenko
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Mesos Reviewbot
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Mesos Reviewbot
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Benjamin Mahler
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Andrei Sekretenko
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Benjamin Mahler
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Andrei Sekretenko
Re: Review Request 72851: Added an endpoint for debugging offer constraints.
Benjamin Mahler
Review Request 72846: Corrected the example of the managed CSI plugin.
Qian Zhang
Re: Review Request 72846: Corrected the example of the managed CSI plugin.
Qian Zhang
Re: Review Request 72846: Corrected the example of the managed CSI plugin.
Mesos Reviewbot
Re: Review Request 72846: Corrected the example of the managed CSI plugin.
Greg Mann
Review Request 72845: Added doc for the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Mesos Reviewbot
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Greg Mann
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Mesos Reviewbot
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Andrei Sekretenko
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Qian Zhang
Re: Review Request 72845: Added doc for the `volume/csi` isolator.
Qian Zhang
Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Andrei Sekretenko
Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Benjamin Mahler
Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Andrei Sekretenko
Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Mesos Reviewbot
Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Andrei Sekretenko
Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.
Mesos Reviewbot
Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call.
Andrei Sekretenko
Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call.
Mesos Reviewbot
Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call.
Mesos Reviewbot
Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call.
Benjamin Mahler
Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf.
Andrei Sekretenko
Re: Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf.
Benjamin Mahler
Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints.
Andrei Sekretenko
Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints.
Benjamin Mahler
Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints.
Andrei Sekretenko
Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints.
Andrei Sekretenko
Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master.
Andrei Sekretenko
Re: Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master.
Benjamin Mahler
Re: Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master.
Andrei Sekretenko
Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`.
Andrei Sekretenko
Re: Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`.
Benjamin Mahler
Review Request 72830: Added a regression test for MESOS-9609.
Benjamin Mahler
Re: Review Request 72830: Added a regression test for MESOS-9609.
Benjamin Mahler
Re: Review Request 72830: Added a regression test for MESOS-9609.
Benjamin Mahler
Re: Review Request 72830: Added a regression test for MESOS-9609.
Greg Mann
Re: Review Request 72830: Added a regression test for MESOS-9609.
Benjamin Mahler
Re: Review Request 72830: Added a regression test for MESOS-9609.
Mesos Reviewbot
Review Request 72831: Fixed a CHECK failure in master during agent removal.
Benjamin Mahler
Re: Review Request 72831: Fixed a CHECK failure in master during agent removal.
Benjamin Mahler
Re: Review Request 72831: Fixed a CHECK failure in master during agent removal.
Greg Mann
Review Request 72832: Avoided unnecessary [] map operators in the master.
Benjamin Mahler
Re: Review Request 72832: Avoided unnecessary [] map operators in the master.
Mesos Reviewbot
Re: Review Request 72832: Avoided unnecessary [] map operators in the master.
Benjamin Mahler
Re: Review Request 72832: Avoided unnecessary [] map operators in the master.
Greg Mann
Re: Review Request 72832: Avoided unnecessary [] map operators in the master.
Benjamin Mahler
Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
Andrei Sekretenko
Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
Benjamin Mahler
Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
Andrei Sekretenko
Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
Andrei Sekretenko
Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.
Qian Zhang
Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.
Mesos Reviewbot
Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.
Greg Mann
Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time.
Andrei Sekretenko
Re: Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time.
Benjamin Mahler
Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
Andrei Sekretenko
Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
Benjamin Mahler
Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
Mesos Reviewbot
Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
Mesos Reviewbot
Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
Andrei Sekretenko
Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Andrei Sekretenko
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Benjamin Mahler
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Andrei Sekretenko
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Benjamin Mahler
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Andrei Sekretenko
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Benjamin Mahler
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Andrei Sekretenko
Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
Andrei Sekretenko
Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED.
Andrei Sekretenko
Re: Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED.
Benjamin Mahler
Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Benjamin Mahler
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Benjamin Mahler
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Benjamin Mahler
Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests.
Andrei Sekretenko
Review Request 72820: Relaxed unknown volume check when unpublishing volumes.
Qian Zhang
Re: Review Request 72820: Relaxed unknown volume check when unpublishing volumes.
Greg Mann
Review Request 72816: Fixed broken authorization in the CSI server.
Greg Mann
Re: Review Request 72816: Fixed broken authorization in the CSI server.
Qian Zhang
Re: Review Request 72816: Fixed broken authorization in the CSI server.
Greg Mann
Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Greg Mann
Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Mesos Reviewbot
Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.
Greg Mann
Earlier messages
Later messages