> On May 26, 2015, 8:13 p.m., Niklas Nielsen wrote:
> > src/tests/resource_estimator.hpp, line 40
> > <https://reviews.apache.org/r/34662/diff/2/?file=971547#file971547line40>
> >
> >     Put { on a newline
> >     Why have create take flags? We tried to make it only take a string.

Yeah, but it was needed since the tests::Module::create receives Flag as 
parameter, so that test class needs to be consistent to have working typed test 
on both RE module and normal RE. 

However, in current review req there are both static "create" methods: one with 
string, second with Flag. Is that resolves your issue?


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85225
-----------------------------------------------------------


On May 27, 2015, 12:15 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 12:15 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2650
>     https://issues.apache.org/jira/browse/MESOS-2650
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added *ResourceEstimator* (RE) module interface. 
> Added *TestResourceEstimator* example module. (Test *ResourceEstimator* 
> module)
> Moved *TestResourceEstimator* to seperate file from *tests/mesos.hpp*
> Changed *oversubscription_tests* to be typed_tested (for normal RE and RE 
> module)
> 
> NOTE: The example modules were good enough for other modules' unit tests, 
> however RE had to be extended - to push particular *Resources* to slave.
> 
> In future if we implement https://issues.apache.org/jira/browse/MESOS-2764, 
> we will be able to inject stubed *Resources* in better way.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/resource_estimator.hpp PRE-CREATION 
>   src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 
>   src/examples/test_resource_estimator_module.cpp PRE-CREATION 
>   src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be 
>   src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba 
>   src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 
>   src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 
>   src/tests/oversubscription_tests.cpp 
> 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 
>   src/tests/resource_estimator.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to