You likely forgot to add the file to your patch. @vinodkone
> On May 27, 2015, at 2:08 AM, Bartek Plotka <[email protected]> wrote: > > > >>> On May 27, 2015, 9 a.m., Mesos ReviewBot wrote: >>> Bad patch! >>> >>> Reviews applied: [34662] >>> >>> Failed command: make -j3 distcheck >>> >>> Error: >>> make dist-gzip am__post_remove_distdir='@:' >>> make[1]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot' >>> if test -d "mesos-0.23.0"; then find "mesos-0.23.0" -type d ! -perm -200 >>> -exec chmod u+w {} ';' && rm -rf "mesos-0.23.0" || { sleep 5 && rm -rf >>> "mesos-0.23.0"; }; else :; fi >>> test -d "mesos-0.23.0" || mkdir "mesos-0.23.0" >>> (cd 3rdparty && make top_distdir=../mesos-0.23.0 >>> distdir=../mesos-0.23.0/3rdparty \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[2]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty' >>> (cd libprocess && make top_distdir=../../mesos-0.23.0 >>> distdir=../../mesos-0.23.0/3rdparty/libprocess \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[3]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess' >>> : >>> test -d "../../mesos-0.23.0/3rdparty/libprocess" || mkdir >>> "../../mesos-0.23.0/3rdparty/libprocess" >>> (cd 3rdparty && make top_distdir=../../../mesos-0.23.0 >>> distdir=../../../mesos-0.23.0/3rdparty/libprocess/3rdparty \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[4]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty' >>> (cd stout && make top_distdir=../../../../mesos-0.23.0 >>> distdir=../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[5]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout' >>> : >>> test -d "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" || >>> mkdir "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" >>> (cd include && make top_distdir=../../../../../mesos-0.23.0 >>> distdir=../../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout/include >>> \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[6]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include' >>> make[6]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include' >>> test -n ":" \ >>> || find "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" >>> -type d ! -perm -755 \ >>> -exec chmod u+rwx,go+rx {} \; -o \ >>> ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \ >>> ! -type d ! -perm -400 -exec chmod a+r {} \; -o \ >>> ! -type d ! -perm -444 -exec /bin/bash >>> /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh >>> -c -m a+r {} {} \; \ >>> || chmod -R a+r >>> "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" >>> make[5]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout' >>> make[4]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty' >>> (cd include && make top_distdir=../../../mesos-0.23.0 >>> distdir=../../../mesos-0.23.0/3rdparty/libprocess/include \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[4]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include' >>> make[4]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include' >>> test -n ":" \ >>> || find "../../mesos-0.23.0/3rdparty/libprocess" -type d ! -perm -755 \ >>> -exec chmod u+rwx,go+rx {} \; -o \ >>> ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \ >>> ! -type d ! -perm -400 -exec chmod a+r {} \; -o \ >>> ! -type d ! -perm -444 -exec /bin/bash >>> /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh >>> -c -m a+r {} {} \; \ >>> || chmod -R a+r "../../mesos-0.23.0/3rdparty/libprocess" >>> make[3]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess' >>> make[2]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty' >>> (cd src && make top_distdir=../mesos-0.23.0 distdir=../mesos-0.23.0/src \ >>> am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: >>> distdir) >>> make[2]: Entering directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src' >>> make[2]: *** No rule to make target >>> `examples/test_resource_estimator_module.hpp', needed by `distdir'. Stop. >>> make[2]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src' >>> make[1]: *** [distdir] Error 1 >>> make[1]: Leaving directory >>> `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot' >>> make: *** [dist] Error 2 > > Strange - i'm sure it works on my machine... any idea? > > "No rule to make target `examples/test_resource_estimator_module.hpp', needed > by `distdir'. Stop" > > > - Bartek > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34662/#review85336 > ----------------------------------------------------------- > > >> On May 27, 2015, 1:34 a.m., Bartek Plotka wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/34662/ >> ----------------------------------------------------------- >> >> (Updated May 27, 2015, 1:34 a.m.) >> >> >> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod >> Kone. >> >> >> Bugs: MESOS-2650 >> https://issues.apache.org/jira/browse/MESOS-2650 >> >> >> Repository: mesos >> >> >> Description >> ------- >> >> Added *ResourceEstimator* (RE) module interface. >> Added *TestResourceEstimator* example module. (Test *ResourceEstimator* >> module) >> Moved *TestResourceEstimator* to seperate file from *tests/mesos.hpp* >> Changed *oversubscription_tests* to be typed_tested (for normal RE and RE >> module) >> >> NOTE: The example modules were good enough for other modules' unit tests, >> however RE had to be extended - to push particular *Resources* to slave. >> >> In future if we implement https://issues.apache.org/jira/browse/MESOS-2764, >> we will be able to inject stubed *Resources* in better way. >> >> >> Diffs >> ----- >> >> include/mesos/module/resource_estimator.hpp PRE-CREATION >> src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 >> src/examples/test_resource_estimator_module.cpp PRE-CREATION >> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be >> src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba >> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 >> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 >> src/tests/oversubscription_tests.cpp >> 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 >> src/tests/resource_estimator.hpp PRE-CREATION >> >> Diff: https://reviews.apache.org/r/34662/diff/ >> >> >> Testing >> ------- >> >> make check >> >> >> Thanks, >> >> Bartek Plotka >
