----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review85380 -----------------------------------------------------------
3rdparty/libprocess/include/process/time.hpp <https://reviews.apache.org/r/34703/#comment136923> This will result in 7 (for each day of week) + 1 (for vector itself) dynamic allocations on each call. Can/should we avoid them using C style structures? Same applies to MONTHS variable. - Nikita Vetoshkin On May 27, 2015, 2:48 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34703/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 2:48 p.m.) > > > Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and > Till Toenshoff. > > > Bugs: mesos-708 > https://issues.apache.org/jira/browse/mesos-708 > > > Repository: mesos > > > Description > ------- > > Adds some manipulator classes which allows formatting Time objects to > ostreams. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/time.hpp > c5ab2a3cfa83590eb6612152ae365dd67f51cea9 > 3rdparty/libprocess/src/tests/time_tests.cpp > be314182c65c05d439b81aa5248a71d93f6f0a0b > > Diff: https://reviews.apache.org/r/34703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
